Allow group owners and admins to manage MOTD server settings
This commit is contained in:
1 parent
2144e218ec
commit
1bbecbfaa1
8 files changed
+352
-14
No files matched your search
@@ -0,0 +1,115 @@
|
||||
import sys
|
||||
import types
|
||||
|
||||
import pytest
|
||||
|
||||
from services.permissions import get_group_role
|
||||
|
||||
|
||||
class Event:
|
||||
def __init__(self, platform="qq_official", raw=None, group="g", user="u", bot=None):
|
||||
self.platform, self.group, self.user, self.bot = platform, group, user, bot
|
||||
self.message_obj = types.SimpleNamespace(raw_message=raw)
|
||||
|
||||
def get_group_id(self):
|
||||
return self.group
|
||||
|
||||
def get_sender_id(self):
|
||||
return self.user
|
||||
|
||||
def get_platform_name(self):
|
||||
return self.platform
|
||||
|
||||
|
||||
@pytest.mark.parametrize("role", ["owner", "admin", "member"])
|
||||
async def test_official_preserved_raw_data(role):
|
||||
raw = types.SimpleNamespace(
|
||||
author=types.SimpleNamespace(member_openid="u"),
|
||||
raw_data={"author": {"member_openid": "u", "member_role": role}, "group_openid": "g"},
|
||||
)
|
||||
assert await get_group_role(Event(raw=raw)) == role
|
||||
|
||||
|
||||
@pytest.fixture
|
||||
def fake_botpy(monkeypatch):
|
||||
class Route:
|
||||
def __init__(self, method, path, **kwargs):
|
||||
self.method, self.path, self.parameters = method, path, kwargs
|
||||
|
||||
module = types.ModuleType("botpy.http")
|
||||
module.Route = Route
|
||||
monkeypatch.setitem(sys.modules, "botpy", types.ModuleType("botpy"))
|
||||
monkeypatch.setitem(sys.modules, "botpy.http", module)
|
||||
|
||||
|
||||
@pytest.mark.parametrize("platform", ["qq_official", "qq_official_webhook"])
|
||||
@pytest.mark.parametrize("role", ["owner", "admin", "member"])
|
||||
async def test_official_authenticated_member_lookup(fake_botpy, platform, role):
|
||||
seen = []
|
||||
|
||||
async def request(route):
|
||||
seen.append(route)
|
||||
return {"member_openid": "u", "member_role": role}
|
||||
|
||||
bot = types.SimpleNamespace(
|
||||
api=types.SimpleNamespace(_http=types.SimpleNamespace(request=request))
|
||||
)
|
||||
assert await get_group_role(Event(platform=platform, bot=bot)) == role
|
||||
assert seen[0].method == "GET"
|
||||
assert seen[0].path == "/v2/groups/{group_openid}/members/{member_openid}"
|
||||
assert seen[0].parameters == {"group_openid": "g", "member_openid": "u"}
|
||||
|
||||
|
||||
@pytest.mark.parametrize(
|
||||
"response",
|
||||
[
|
||||
{"member_openid": "wrong-user", "member_role": "owner"},
|
||||
{"member_openid": "u", "member_role": "admin", "group_openid": "wrong-group"},
|
||||
{"code": 11253, "message": "API not enabled"},
|
||||
None,
|
||||
],
|
||||
)
|
||||
async def test_wrong_identity_or_unavailable_official_api_never_grants(fake_botpy, response):
|
||||
async def request(route):
|
||||
return response
|
||||
|
||||
bot = types.SimpleNamespace(
|
||||
api=types.SimpleNamespace(_http=types.SimpleNamespace(request=request))
|
||||
)
|
||||
assert await get_group_role(Event(bot=bot)) is None
|
||||
|
||||
|
||||
async def test_onebot_live_lookup_passes_routing_and_no_cache():
|
||||
seen = []
|
||||
|
||||
async def action(name, **kwargs):
|
||||
seen.append((name, kwargs))
|
||||
return {"user_id": 2, "group_id": 1, "role": "owner"}
|
||||
|
||||
bot = types.SimpleNamespace(call_action=action)
|
||||
event = Event("aiocqhttp", raw={"self_id": 123}, group="1", user="2", bot=bot)
|
||||
assert await get_group_role(event) == "owner"
|
||||
assert seen == [
|
||||
("get_group_member_info", {"group_id": 1, "user_id": 2, "no_cache": True, "self_id": 123})
|
||||
]
|
||||
|
||||
|
||||
async def test_api_failure_denies_without_crashing(fake_botpy):
|
||||
async def request(route):
|
||||
raise PermissionError("not enabled")
|
||||
|
||||
bot = types.SimpleNamespace(
|
||||
api=types.SimpleNamespace(_http=types.SimpleNamespace(request=request))
|
||||
)
|
||||
assert await get_group_role(Event(bot=bot)) is None
|
||||
|
||||
|
||||
async def test_mismatched_incoming_author_and_message_text_do_not_grant():
|
||||
assert (
|
||||
await get_group_role(
|
||||
Event(raw={"author": {"member_openid": "wrong", "member_role": "owner"}})
|
||||
)
|
||||
is None
|
||||
)
|
||||
assert await get_group_role(Event(raw={"content": '{"member_role": "owner"}'})) is None
|
||||
assert await get_group_role(Event(raw={"author": {"member_role": "admin"}}, group="")) is None
|
||||
+78
-2
@@ -10,8 +10,19 @@ import pytest
|
||||
|
||||
|
||||
class Event:
|
||||
def __init__(self, platform="qq-main", group="group-openid", admin=False, image_error=False):
|
||||
def __init__(
|
||||
self,
|
||||
platform="qq-main",
|
||||
group="group-openid",
|
||||
admin=False,
|
||||
image_error=False,
|
||||
platform_name="qq_official",
|
||||
raw=None,
|
||||
user="user-openid",
|
||||
):
|
||||
self.platform, self.group, self.admin = platform, group, admin
|
||||
self.platform_name, self.user = platform_name, user
|
||||
self.message_obj = types.SimpleNamespace(raw_message=raw)
|
||||
self.image_error = image_error
|
||||
self.unified_msg_origin = f"{platform}:private:user"
|
||||
self.messages = []
|
||||
@@ -23,8 +34,11 @@ class Event:
|
||||
def get_platform_id(self):
|
||||
return self.platform
|
||||
|
||||
def get_platform_name(self):
|
||||
return self.platform_name
|
||||
|
||||
def get_sender_id(self):
|
||||
return "user-openid"
|
||||
return self.user
|
||||
|
||||
def is_admin(self):
|
||||
return self.admin
|
||||
@@ -146,3 +160,65 @@ async def test_missing_default_invalid_and_private_setting(plugin_class):
|
||||
await plugin.motd(event, "help")
|
||||
assert "/mcstatus" in event.messages[-1][1]
|
||||
await plugin.terminate()
|
||||
|
||||
|
||||
@pytest.mark.parametrize("platform_name", ["qq_official", "qq_official_webhook", "aiocqhttp"])
|
||||
@pytest.mark.parametrize("role", ["owner", "admin", "member"])
|
||||
async def test_group_roles_can_set_and_clear_only_when_privileged(
|
||||
plugin_class, platform_name, role
|
||||
):
|
||||
plugin = plugin_class(object(), {"history_enabled": False})
|
||||
|
||||
async def no_send(*args):
|
||||
pass
|
||||
|
||||
plugin._query_and_send = no_send
|
||||
raw = (
|
||||
{"sender": {"role": role}}
|
||||
if platform_name == "aiocqhttp"
|
||||
else {"author": {"member_role": role}}
|
||||
)
|
||||
event = Event(platform_name=platform_name, raw=raw)
|
||||
await plugin.motd(event, "set", "a.test")
|
||||
scope = plugin._scope(event)
|
||||
if role == "member":
|
||||
assert await plugin.store.get_binding(scope) is None
|
||||
assert "暂时无法核实" not in event.messages[-1][1]
|
||||
await plugin.store.set_binding(scope, "original.test", "bot-admin")
|
||||
await plugin.motd(event, "unset")
|
||||
assert await plugin.store.get_binding(scope) == "original.test"
|
||||
else:
|
||||
assert await plugin.store.get_binding(scope) == "a.test"
|
||||
await plugin.motd(event, "unset")
|
||||
assert await plugin.store.get_binding(scope) is None
|
||||
await plugin.terminate()
|
||||
|
||||
|
||||
async def test_group_grant_is_limited_to_one_group_and_adapter(plugin_class):
|
||||
plugin = plugin_class(
|
||||
object(),
|
||||
{"history_enabled": False, "group_admin_ids": ["qq-main|group-openid|user-openid"]},
|
||||
)
|
||||
|
||||
async def no_send(*args):
|
||||
pass
|
||||
|
||||
plugin._query_and_send = no_send
|
||||
event = Event()
|
||||
await plugin.motd(event, "set", "a.test")
|
||||
assert await plugin.store.get_binding(plugin._scope(event)) == "a.test"
|
||||
for outsider in [
|
||||
Event(group="another-group"),
|
||||
Event(platform="another-bot"),
|
||||
Event(user="another-user"),
|
||||
]:
|
||||
await plugin.motd(outsider, "set", "unauthorized.test")
|
||||
assert "无法核实" in outsider.messages[-1][1]
|
||||
if outsider.group != event.group or outsider.platform != event.platform:
|
||||
assert await plugin.store.get_binding(plugin._scope(outsider)) is None
|
||||
else:
|
||||
assert await plugin.store.get_binding(plugin._scope(outsider)) == "a.test"
|
||||
await plugin.motd(event, "identity")
|
||||
assert "qq-main|group-openid|user-openid" in event.messages[-1][1]
|
||||
assert not plugin._is_admin(event)
|
||||
await plugin.terminate()
|
||||
Reference in new issue
Block a user