import base64 import hashlib import io import json import tempfile import unittest from pathlib import Path from unittest.mock import MagicMock, patch import zipfile import yaml import app from review_tools import review_export, review_import, review_validate class CodeReviewTests(unittest.TestCase): def test_snapshot_copy_is_separate_stable_and_excludes_credentials(self): with tempfile.TemporaryDirectory() as directory: source=Path(directory)/'source';target=Path(directory)/'review';source.mkdir();target.mkdir() (source/'index.html').write_text('Test') (source/'styles.css').write_text('body { color: red; }') (source/'.env').write_text('API_KEY=never-copy') (source/'.npmrc').write_text('//registry:token=never-copy') snapshot=review_export(source) self.assertEqual(['index.html','styles.css'],[f['path'] for f in snapshot['files']]) self.assertEqual(snapshot['sourceHash'],review_export(source)['sourceHash']) review_import(target,snapshot) self.assertFalse((target/'.env').exists()) result=review_validate(target) self.assertEqual('PASSED',result['steps'][0]['status']) self.assertEqual('NOT_RUN',result['browser']['status']) (target/'index.html').write_text('copy was changed') self.assertNotEqual((source/'index.html').read_text(),(target/'index.html').read_text()) with self.assertRaises(ValueError):review_import(target,snapshot) def test_missing_asset_is_a_real_failure_not_an_ai_claim(self): with tempfile.TemporaryDirectory() as directory: source=Path(directory)/'source';target=Path(directory)/'target';source.mkdir();target.mkdir() (source/'index.html').write_text('Missing CSS') review_import(target,review_export(source)) result=review_validate(target) self.assertEqual('FAILED',result['steps'][0]['status']) self.assertIn('absent.css',result['steps'][0]['issues'][0]['message']) def test_missing_navigation_target_is_not_accepted(self): with tempfile.TemporaryDirectory() as directory: source=Path(directory)/'source';target=Path(directory)/'target';source.mkdir();target.mkdir() (source/'index.html').write_text('IncompleteProjects') review_import(target,review_export(source));result=review_validate(target) self.assertEqual('FAILED',result['steps'][0]['status']) self.assertIn('#projects',result['steps'][0]['issues'][0]['message']) def test_archive_tampering_and_zip_slip_are_rejected_before_writes(self): with tempfile.TemporaryDirectory() as directory: target=Path(directory)/'target';target.mkdir() data=io.BytesIO() with zipfile.ZipFile(data,'w') as archive:archive.writestr('../outside.txt','denied') snapshot={'archive':base64.b64encode(data.getvalue()).decode(),'archiveSha256':hashlib.sha256(data.getvalue()).hexdigest(),'sourceHash':'0'*64} with self.assertRaises(ValueError):review_import(target,snapshot) self.assertEqual([],list(target.iterdir())) self.assertFalse((Path(directory)/'outside.txt').exists()) snapshot['archiveSha256']='0'*64 with self.assertRaises(ValueError):review_import(target,snapshot) def test_review_cleanup_has_no_delete_permission_in_development_namespace(self): root=Path(__file__).parents[1]/'infra/k8s' development=list(yaml.safe_load_all((root/'sandbox-rbac.yaml').read_text())) review=list(yaml.safe_load_all((root/'review-rbac.yaml').read_text())) self.assertFalse(any('delete' in rule['verbs'] for r in development if r['kind']=='Role' for rule in r['rules'])) self.assertTrue(any('delete' in rule['verbs'] for r in review if r['kind']=='Role' for rule in r['rules'])) self.assertTrue(all(r['metadata']['namespace']=='platform-reviews' for r in review if r['kind']=='Role')) def test_large_payload_uses_stdin_instead_of_command_arguments(self): connection=MagicMock();connection.is_open.side_effect=[True,False] connection.peek_stdout.return_value=True;connection.read_stdout.return_value='{"written":192000}' connection.peek_stderr.return_value=False;connection.returncode=0 project='00000000-0000-0000-0000-000000000001' with patch.object(app,'TOKEN','x'*32),patch.object(app,'ensure_workspace'),patch.object(app.client,'ApiClient'),patch.object(app,'stream',return_value=connection) as stream: result=app.tool(project,app.Tool(name='write_file',arguments={'path':'big.txt','content':'中'*64000}),'Bearer '+'x'*32) self.assertEqual(192000,result['written']) self.assertLess(len(stream.call_args.kwargs['command'][-1].encode()),128000) encoded=''.join(call.args[0] for call in connection.write_stdin.call_args_list) self.assertEqual('中'*64000,json.loads(base64.b64decode(encoded))['arguments']['content']) def test_cleanup_cannot_point_at_development_namespace(self): with patch.object(app,'TOKEN','x'*32),patch.object(app,'REVIEW_NAMESPACE',app.NAMESPACE): with self.assertRaises(app.HTTPException):app.dispose_review('00000000-0000-0000-0000-000000000001','Bearer '+'x'*32)